mcp-server: return 200 for bare GET health probes#347
Conversation
Directory crawlers like Glama probe MCP endpoints with a plain GET (no Accept: text/event-stream header). The MCP SDK rejects these with 406, but crawlers interpret that as "server unhealthy". Intercept non-MCP GETs in the request handler and return a friendly JSON status. Real MCP clients always send the SSE Accept header and are unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40ce162b44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // a friendly JSON status so directory health-probes (Glama, uptime monitors) | ||
| // see a 200 instead of the SDK's opaque 406. | ||
| const accept = req.headers.accept ?? '' | ||
| if (req.method === 'GET' && !accept.includes('text/event-stream')) { |
There was a problem hiding this comment.
HTTP media types are case-insensitive, so valid MCP clients can legally send mixed-case values like Accept: Text/Event-Stream. This check is case-sensitive, which means those requests are misclassified as health probes and get a 200 JSON status body instead of reaching transport.handleRequest, breaking the Streamable HTTP handshake for that client behavior. Converting the header to lowercase (or using media-type parsing) before matching would preserve compatibility.
Useful? React with 👍 / 👎.
1 participant
Summary
GET /mcp(noAccept: text/event-streamheader)mcp.stripe.comreturns 401 on bare GET — crawlers read that as "alive but needs auth"api2.transloadit.com/mcpcurrently shows as Unhealthy on Glama, blocking our PR on punkpeye/awesome-mcp-servers#1912 (80k stars)Fix
Intercept bare GET requests (without
Accept: text/event-stream) inhttp-request-handler.tsbefore they reach the SDK transport. Return a friendly JSON response:{"name":"Transloadit MCP Server","status":"ok","docs":"https://transloadit.com/docs/sdks/mcp-server/"}Real MCP clients always send
Accept: text/event-stream(required by the Streamable HTTP spec), so they bypass this and reach the transport as before.Test plan
yarn check)🤖 Generated with Claude Code